Open
Conversation
Author
|
@sidcha could you please check why PlatformIO is failing? |
sidcha
reviewed
Apr 18, 2026
|
|
||
| void osdp_fill_zeros(void *buf, int len) | ||
| { | ||
| explicit_bzero(buf, (size_t)len); |
Member
There was a problem hiding this comment.
explicit_bzero() is a glibc/BSD extension, AVR libc does not provide it. Please replace this with a more portable version:
Suggested change
| explicit_bzero(buf, (size_t)len); | |
| volatile uint8_t *p = (volatile uint8_t *)buf; | |
| while (len--) | |
| *p++ = 0; |
|
|
||
| #include <stdint.h> | ||
| #include <stdlib.h> | ||
| #include <string.h> |
Member
There was a problem hiding this comment.
With the suggestion below above, you should drop this too.
Member
|
Also please extend the commit message to include the context explained in #296 so git blames at a later time will have more meaningful information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #296